Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken tests on 4.4 #14

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix broken tests on 4.4 #14

merged 2 commits into from
Aug 24, 2023

Conversation

zach-iee
Copy link

@zach-iee zach-iee commented Aug 24, 2023

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fix broken tests caused by #7 and apply redis#2809

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch coverage: 93.63% and project coverage change: +31.29% 🎉

Comparison is base (e4408a9) 60.21% compared to head (a54865f) 91.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##              4.4      #14       +/-   ##
===========================================
+ Coverage   60.21%   91.51%   +31.29%     
===========================================
  Files         116      116               
  Lines       30281    30271       -10     
===========================================
+ Hits        18234    27702     +9468     
+ Misses      12047     2569     -9478     
Files Changed Coverage Δ
tests/test_commands.py 90.00% <93.51%> (+21.03%) ⬆️
tests/test_asyncio/test_graph.py 99.23% <100.00%> (+80.69%) ⬆️
tests/test_graph.py 91.58% <100.00%> (+74.40%) ⬆️

... and 79 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zach-iee zach-iee merged commit a76278a into 4.4 Aug 24, 2023
38 checks passed
@zach-iee zach-iee deleted the 4.4_test_fix branch August 24, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants