fix: Fixed markdown message in channel preview #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AhyoungRyu
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Could you add unit tests for the newly added ones?
There was a problem hiding this comment.
Added unit tests @AhyoungRyu
chohongm
force-pushed
the
fix/CLNP-4063-fix-markdown-message-in-channel-preview
branch
from
3c10f9f to
1000c09
Compare
HoonBaek
approved these changes
Aug 21, 2024
| }; | ||
|
|
||
| export const getLastMessage = (channel?: GroupChannel, stringSet = LabelStringSet) => channel?.lastMessage ? getPrettyLastMessage(channel?.lastMessage, stringSet) : ''; | ||
| export const getLastMessage = (channel?: GroupChannel, stringSet = LabelStringSet) => { |
There was a problem hiding this comment.
이전에는 stringSet을 params로 넣는 방식을 택했었는데, 이제는 LocalizationContext에서 직접 가져오는 것도 괜찮을 것 같습니다.
There was a problem hiding this comment.
const { stringSet } = useLocalization();
을 함수 안에 추가하는 방향일까요?
There was a problem hiding this comment.
getLastMessage 는 현재 쓰이고 있는 곳들이 많아서 나중에 따로 보면 좋을것 같습니다
| const { dateLocale, stringSet } = useLocalization(); | ||
| const { isMobile } = useMediaQueryContext(); | ||
| const isMentionEnabled = config.groupChannel.enableMention; | ||
| const lastMessage = getLastMessage(channel, stringSet); |
There was a problem hiding this comment.
getLastMessage의 이름을 보면 return값이 BaseMessage 등의 메시지 일 것 같은데
실제로는 string값이네요 좀 더 나은 이름이 있을까요? ex. getLastMessageText
chohongm
deleted the
fix/CLNP-4063-fix-markdown-message-in-channel-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CLNP-4063
Changelogs
Disabled
Enabled