[CLNP-4962] fix: prevent HTML entity conversion by using insertText in document.execCommand #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Isn't it |
|
No no the next release will be 3.15.0 https://sendbird.slack.com/archives/G01290GCDCN/p1724658756997849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue https://sendbird.atlassian.net/browse/CLNP-4962
where HTML entities like
§or<were being automatically converted to their corresponding symbols (§ or >) when pasting content into a contentEditable element.Changes
The
document.execCommand('insertHTML', false, sanitizeString(text))command was replaced withdocument.execCommand('insertText', false, sanitizeString(text)).This change ensures that HTML entities are inserted as plain text rather than being interpreted and converted by the browser. Now it prevents unintended conversion of HTML entities, maintaining the original text as expected when pasting content.
How to test?
Try this on the preview.
Type
§and copy & paste the text to the input box. The exact same text(=§) should be on the input not§.