[v3.2.1] (Oct 04 2022) #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoonBaek
approved these changes
Sep 30, 2022
Fixes: * Do not bundle chat SDK with uikit compiled code Compiled UIKit code that is distributed through npm shouldn't have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit Advantages: * Chat SDK bug fixes will be added for free * Eliminate the need for handlers What caused the issue: If you are using rollup for bundling in config.external you have to be specific ie> This works: ``` external: [ '@sendbird/chat', '@sendbird/chat/groupChannel', '@sendbird/chat/openChannel', '@sendbird/chat/message', ] ``` This doesn't: ``` external: [ '@sendbird/chat', ] ``` * Only react and react-dom should be peerDependencies For npm >= v7, npm autoinstall peerDependency packages According to `https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies` You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool
sravan-s
force-pushed
the
release/3.2.1
branch
from
5cccd02 to
c0bee8a
Compare
sravan-s
added a commit
that referenced
this pull request
Oct 4, 2022
Fixes: * Donot bundle chat sdk with uikit compiled code Compiled UIKit code that is distributed through npm shouldnt have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit Advantages: * Chat SDK bug fixes will be added for free * Eliminate the need for handlers What caused the issue: If you are usig rollup for bundling in config.external you have to be specific ie> This works: ``` external: [ '@sendbird/chat', '@sendbird/chat/groupChannel', '@sendbird/chat/openChannel', '@sendbird/chat/message', ] ``` This doesnt: ``` external: [ '@sendbird/chat', ] ``` * Only react and react-dom should be peerDependencies For npm >= v7, npm autoinstall peerDependency packages According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Compiled UIKit code that is distributed through npm shouldnt have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit
Advantages:
If you are usig rollup for bundling
in config.external you have to be specific
ie>
This works:
This doesnt:
For npm >= v7, npm autoinstall peerDependency packages According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool