[v3.2.4] (Nov 1 2022) #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
release/3.2.4
branch
2 times, most recently
from
8a2fad1 to
61b61a5
Compare
HoonBaek
approved these changes
Nov 2, 2022
sravan-s
force-pushed
the
release/3.2.4
branch
2 times, most recently
from
9ebb394 to
7484fdd
Compare
Fix:
* React UIkit loading screen rendering issue
- For Channel component, added seperate prop isLoading?.boolean
Usage:
```
<Channel channelUrl={currentChannelUrl} isLoading={!currentChannelUrl} />
```
- For flicker in ChannelList, without extra props
* Fix scroll issue in ChannelList where user cannot load more channels
* Modify ts interface getLeaveChannel to getLeaveGroupChannel in selectors
sravan-s
force-pushed
the
release/3.2.4
branch
from
7484fdd to
1283ad9
Compare
sravan-s
pushed a commit
that referenced
this pull request
Nov 2, 2022
Features:
* For Channel component, added separate prop isLoading?.boolean Usage: ```<Channel channelUrl {currentChannelUrl} isLoading={!currentChannelUrl} />```
* For flicker in ChannelList, without extra props
Fixes:
* React UIKit placeholder rendering issue
* Fix scroll issue in ChannelList where user cannot load more channels
* Modify TS interface getLeaveChannel to getLeaveGroupChannel in selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
<Channel channelUrl {currentChannelUrl} isLoading={!currentChannelUrl} />Fixes: