Skip to content

fix: Allow overriding entire message search query #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: Allow overriding entire message search query #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/smart-components/MessageSearch/context/hooks/useGetSearchedMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ function useGetSearchedMessages(
if (sdk && channelUrl && sdk.createMessageSearchQuery && currentChannel) {
if (requestString) {
const inputSearchMessageQueryObject: MessageSearchQueryParams = {
...messageSearchQuery,
order: MessageSearchOrder.TIMESTAMP,
channelUrl,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to override? I think we explicitly didnt wanted to do this before

Anyways, please add comment with ticket number before merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the other platforms are allowing to override messageSearchQuery.

messageTimestampFrom: currentChannel.invitedAt,
keyword: requestString,
...messageSearchQuery,
};
const createdQuery = sdk.createMessageSearchQuery(inputSearchMessageQueryObject);
createdQuery.next().then((messages) => {
Expand Down