fix: Include renderIconButton into the renderHeader range #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoonBaek
added
Ready for review
in progress
Warn for the case using renderHeader
sravan-s
reviewed
Dec 7, 2022
|
|
||
| interface ChannelListHeaderInterface { | ||
| renderHeader?: (props: void) => React.ReactElement; | ||
| renderTitle?: () => React.ReactElement; |
There was a problem hiding this comment.
add type definition, and in the file you can comment deprecation
sravan-s
approved these changes
Dec 7, 2022
HoonBaek
deleted the
fix/UIKIT-2654/Props-renderHeader-should-include-renderIconButton
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
UIKIT-2654
Description Of Changes
Issue
The create channel button range has been displayed even
renderHeaderprops are setFix
Include the
create channel button & renderIconButtoninto therenderHeader and ChannelListHeaderrangeTypes Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_