Skip to content

fix: Change the type definition of messageSearchQuery #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: Change the type definition of messageSearchQuery #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/index_d_ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ declare module "SendbirdUIKitGlobal" {
FileMessageCreateParams,
MessageListParams,
MessageSearchQuery,
MessageSearchQueryParams,
UserMessage,
UserMessageCreateParams,
UserMessageUpdateParams,
Expand Down Expand Up @@ -848,7 +849,7 @@ declare module "SendbirdUIKitGlobal" {
children?: React.ReactNode | React.ReactElement;
searchString?: string;
requestString?: string;
messageSearchQuery?: MessageSearchQuery;
messageSearchQuery?: MessageSearchQueryParams;
onResultLoaded?(messages?: Array<ClientSentMessages>, error?: SendbirdError): void;
onResultClick?(message: ClientSentMessages): void;
}
Expand Down
3 changes: 2 additions & 1 deletion src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import type {
FileMessageCreateParams,
UserMessageUpdateParams,
MessageListParams,
MessageSearchQueryParams,
} from '@sendbird/chat/message';
import type {
Member,
Expand Down Expand Up @@ -1147,7 +1148,7 @@ export interface MessageSearchProviderProps {
children?: React.ReactElement;
searchString?: string;
requestString?: string;
messageSearchQuery?: MessageSearchQuery;
messageSearchQuery?: MessageSearchQueryParams;
onResultLoaded?(messages?: Array<ClientSentMessages>, error?: SendbirdError): void;
onResultClick?(message: ClientSentMessages): void;
}
Expand Down
2 changes: 1 addition & 1 deletion src/smart-components/MessageSearch/context/MessageSearchProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ interface MessageSearchProviderInterface extends MessageSearchProviderProps {
setRetryCount: React.Dispatch<React.SetStateAction<number>>;
selectedMessageId: number;
setSelectedMessageId: React.Dispatch<React.SetStateAction<number>>;
messageSearchDispatcher: ({ type: string, payload: any }) => void;
messageSearchDispatcher: (props: { type: string, payload: any }) => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

scrollRef: React.MutableRefObject<HTMLDivElement>;
allMessages: MessageSearchReducerState['allMessages'];
loading: boolean;
Expand Down
2 changes: 1 addition & 1 deletion src/smart-components/MessageSearch/context/hooks/useGetSearchedMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ interface MainProps {
interface ToolProps {
sdk: SendbirdGroupChat;
logger: Logger;
messageSearchDispatcher: ({ type: string, payload: any }) => void;
messageSearchDispatcher: (props: { type: string, payload: any }) => void;
}

function useGetSearchedMessages(
Expand Down