fix: Apply string set into the moderation section #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
reviewed
Feb 1, 2023
| > | ||
| <> | ||
| {stringSet.CHANNEL_SETTING__UNMUTE} | ||
| {stringSet.CHANNEL_SETTING__MODERATION__UNMUTE} |
There was a problem hiding this comment.
This might be breaking chnage
There was a problem hiding this comment.
Suggested change
| {stringSet.CHANNEL_SETTING__MODERATION__UNMUTE} | |
| {stringSet?.CHANNEL_SETTING__UNMUTE || stringSet.CHANNEL_SETTING__MODERATION__UNMUTE} |
sravan-s
approved these changes
Feb 1, 2023
HoonBaek
deleted the
fix/UIKIT-2766/Missing-string-set-in-channel-settings
branch
HoonBaek
added a commit
that referenced
this pull request
Feb 2, 2023
* Add string set
* CHANNEL_SETTING__OPERATORS__ADD_BUTTON: 'Add'
* CHANNEL_SETTING__MODERATION__EMPTY_BAN: 'No banned members yet'
* CHANNEL_SETTING__MODERATION__ALL_BAN: 'All banned members'
* Apply string set
* on the BannedUserList component
* `No banned members yet`
* `All banned members`
* `Unban` on the context menu of the banned user list
* on the BannedUsersModal component
* `Unban` on the context menu of the banned user list
* on the AddOperatorsModal component
* `Add` for the submit button
* on the InviteUsersModal component
* `Invite` for the submit button
* on the MutedMembersModal component
* `Unmute` on the context menu of the muted user list
* Remove string set
* CHANNEL_SETTING__UNMUTE: 'Unmute'
* Replace the string set to CHANNEL_SETTING__MODERATION__UNMUTE on the MutedMemberList component
* Modify CSS
* To improve the word break with StringSet customization on the submit button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
UIKIT-2766
Description Of Changes
Add string set
Apply string set
No banned members yetAll banned membersUnbanon the context menu of the banned user listUnbanon the context menu of the banned user listAddfor the submit buttonInvitefor the submit buttonUnmuteon the context menu of the muted user listRemove string set
Replace the string set to CHANNEL_SETTING__MODERATION__UNMUTE on the MutedMemberList component
Modify CSS
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_