Skip to content

fix: Ask for stream only when recording #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

fix: Ask for stream only when recording #415

merged 1 commit into from
Mar 2, 2023

Conversation

HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Mar 1, 2023

Description Of Changes

  • Get stream when requesting record start to disappear the red record icon on the browser tap that always appears

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)

@HoonBaek HoonBaek requested a review from sravan-s March 1, 2023 17:31
@HoonBaek HoonBaek self-assigned this Mar 1, 2023
@HoonBaek HoonBaek merged commit 5f6dd6b into develop/Voice-message Mar 2, 2023
@HoonBaek HoonBaek deleted the fix/Activate-stream-permission-only-when-recording branch March 2, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sravan-s sravan-s sravan-s approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@HoonBaek HoonBaek

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HoonBaek @sravan-s @EunSeo-Baek