Skip to content

fix: Do not play voice message when VoiceRecorder is recording #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix: Do not play voice message when VoiceRecorder is recording #421

merged 1 commit into from
Mar 3, 2023

Conversation

HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Mar 3, 2023 •
edited by atlassian bot
Loading

For Internal Contributors

QM-2598

Description Of Changes

  • Do not play voice message when VoiceRecorder is recording

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)

@HoonBaek HoonBaek requested a review from sravan-s March 3, 2023 03:15
@HoonBaek HoonBaek self-assigned this Mar 3, 2023
@HoonBaek HoonBaek changed the base branch from main to develop/Voice-message March 3, 2023 03:16
@HoonBaek HoonBaek merged commit 19eed0d into develop/Voice-message Mar 3, 2023
@HoonBaek HoonBaek deleted the fix/QM-2598/Block-to-play-during-recording branch March 3, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sravan-s sravan-s sravan-s approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@HoonBaek HoonBaek

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HoonBaek @sravan-s @EunSeo-Baek