Skip to content

Conversation

HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Mar 3, 2023

For Internal Contributors

QM-2594
QM-2601

Description Of Changes

  • Apply throttling to the VoiceMessageInput component
  • Do not pause voice player when empty useVoicePlayer is unmounted

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)

@HoonBaek HoonBaek requested a review from sravan-s March 3, 2023 07:05
@HoonBaek HoonBaek self-assigned this Mar 3, 2023
(voiceAudioPlayerElement as HTMLAudioElement)?.pause?.();
if (audioFile || audioFileUrl) {
// Can't get the current AudioPlayer through the React hooks(useReducer or useState) in this scope
const voiceAudioPlayerElement = document.getElementById(VOICE_PLAYER_AUDIO_ID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ref later ~

@HoonBaek HoonBaek changed the title Fix/qm 2594/modify click event of voice message input fix: Modify handling click event of VoiceMessageInput Mar 3, 2023
@HoonBaek HoonBaek merged commit d300a99 into develop/Voice-message Mar 3, 2023
@HoonBaek HoonBaek deleted the fix/QM-2594/Modify-click-event-of-VoiceMessageInput branch March 3, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants