fix: OpenChannel Context menu click leak #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OGMessage should fallback to text-message * Mobile ContextMenus should be outside TouchHandlers
sravan-s
commented
Jun 7, 2023
Comment on lines
+20
to
+28
| type MessageTypeOptions = { | ||
| isOgMessageEnabledInOpenChannel?: boolean; | ||
| }; | ||
|
|
||
| export const getMessageType = ( | ||
| message: UserMessage | FileMessage | AdminMessage, | ||
| options?: MessageTypeOptions, | ||
| ): string => { | ||
| const isOgMessageEnabledInOpenChannel = options?.isOgMessageEnabledInOpenChannel; |
There was a problem hiding this comment.
cc @AhyoungRyu , its better to fallback to text message when og message is not present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Mobile,
Touch from contextMenus were getting leaked to MessageBody
To avoid this, move context menu outside of MessageBody's JSX
to
Bonus * OGMessage should fallback to text-messages
Fixes: https://sendbird.atlassian.net/browse/UIKIT-4029