-
Notifications
You must be signed in to change notification settings - Fork 66
Closed
Labels
difficulty: easyfix is easy in difficultyfix is easy in difficultystatus: work in progressTwilio or the community is in the process of implementingTwilio or the community is in the process of implementingtype: securityknown security issueknown security issue
Description
Issue Summary
...
CURLOPT_SSL_VERIFYPEER => false
...
Steps to Reproduce
- Install the library.
- Use it.
- Get a MITM attacker
- Don't notice it because we're not validating SSL certificates
Technical details:
- php-http-client Version: master
- PHP Version: 7.1
Why would you disable SSL peer verification by default in a library??
At the very least people incapable of configuring their servers decently should disable security options manually. Current it's the other way around and only people randomly inspecting source code notice that you're disabling SSL security features by default...
thinkingserious
Metadata
Metadata
Assignees
Labels
difficulty: easyfix is easy in difficultyfix is easy in difficultystatus: work in progressTwilio or the community is in the process of implementingTwilio or the community is in the process of implementingtype: securityknown security issueknown security issue