Disable CURLOPT_FAILONERROR to properly set body for non 2xx-responses. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making a request that returns in a status code other than 2xx, Curl would output the response to STDOUT instead of part of the response in the `curl_exec` call. This would cause the Response object returned from Client::makeRequest to contain nothing in the body. By telling curl not to fail on error, the body is left intact in the response from `curl_exec`, and the body is set as expected in the Response object returned from Client::makeRequest.
thinkingserious
added
status: cla needed
type: community enhancement
|
Hello @adduc, Thanks for the PR! We have #13 merged now. For us to review and merge, we need a signed CLA. Can you please do that for us? Thanks! |
|
Hi @adduc, Just checking in. Do you still want this issue to be merged? Thanks! |
|
Hello @adduc, Would you like for us to make this change ourselves? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a request that returns in a status code other than 2xx, Curl would
output the response to STDOUT instead of part of the response in the
curl_execcall. This would cause the Response object returned from Client::makeRequest to
contain nothing in the body. By telling curl not to fail on error, the body is
left intact in the response from
curl_exec, and the body is set as expectedin the Response object returned from Client::makeRequest.
This resolves the errors being output to screen as reported in sendgrid/sendgrid-php#321.