Skip to content

Conversation

pushkyn
Copy link
Contributor

@pushkyn pushkyn commented Oct 30, 2017

Fixes #57

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • add unit test for license year

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@pushkyn pushkyn force-pushed the add-test-license-year branch from a803fd9 to 3a1eff7 Compare October 30, 2017 10:02
@pushkyn pushkyn force-pushed the add-test-license-year branch from 3a1eff7 to ce2a5d5 Compare November 8, 2017 19:17
@thinkingserious thinkingserious merged commit 6df942f into sendgrid:master Jan 23, 2018
@thinkingserious
Copy link
Contributor

Hello @pushkyn,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a unittest to check the license.md file date range
3 participants