Skip to content

Conversation

thinkingserious
Copy link
Contributor

@thinkingserious thinkingserious commented Mar 11, 2018

Fixes issue 584 in sendgrid-php.

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio labels Mar 11, 2018
@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   80.66%   80.66%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          146      146           
  Misses         35       35
Impacted Files Coverage Δ
lib/Client.php 77.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46dcffa...05b84e6. Read the comment docs.

@thinkingserious thinkingserious merged commit f307874 into master Mar 11, 2018
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious deleted the header-overwrite-bug branch March 11, 2018 15:33
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Don't overwrite headers set from upstream dependencies
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant