Skip to content

Fix Constructor Signature #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix Constructor Signature #96

merged 1 commit into from
Mar 23, 2018

Conversation

thinkingserious
Copy link
Contributor

@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing status: code review request requesting a community code review or review from Twilio labels Mar 23, 2018
@codecov
Copy link

codecov bot commented Mar 23, 2018 •
edited
Loading

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   80.66%   80.66%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          146      146           
  Misses         35       35
Impacted Files Coverage Δ
lib/Client.php 77.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15fa0d2...83de466. Read the comment docs.

@thinkingserious thinkingserious merged commit 281a760 into master Mar 23, 2018
@thinkingserious
Copy link
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Mar 23, 2018
@thinkingserious
Version Bump:v3.9.4: #96: Fix constructor function signature
08fe96a
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
Merge pull request sendgrid#96 from sendgrid/fix_constructor_sig
22c66e1 
Fix Constructor Signature
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
@thinkingserious
Version Bump:v3.9.4: sendgrid#96: Fix constructor function signature
d80f52f
@childish-sambino childish-sambino deleted the fix_constructor_sig branch January 16, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkingserious