Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize #436

Closed
thinkingserious opened this issue Oct 4, 2017 · 12 comments · Fixed by #535
Closed

Dockerize #436

thinkingserious opened this issue Oct 4, 2017 · 12 comments · Fixed by #535

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 4, 2017

We want to make it easier to test and/or contribute to this repo utilizing Docker. This has been completed in Python, please use that example as a reference.

Key features:

  • Setup the environment as specified in the CONTRIBUTING.md file
  • Prism should be running on launch
  • The README and USAGE file should help the user get up and running quickly
  • Use docker-compose in order to set up a local shared volume for the library files
@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 4, 2017
@samundra
Copy link
Contributor

samundra commented Oct 4, 2017

I want to have a look at this one.

@Luciam91
Copy link

Luciam91 commented Oct 6, 2017

Is this for a development environment, or a production one?

@samundra
Copy link
Contributor

samundra commented Oct 6, 2017 via email

@Luciam91
Copy link

Luciam91 commented Oct 6, 2017

Perfect, I'll wait for you to get this done @samundra if you're still working on it :)

@samundra
Copy link
Contributor

samundra commented Oct 6, 2017 via email

@mbernier
Copy link

How's it going @samundra? Anything we can help with?

@samundra
Copy link
Contributor

samundra commented Oct 21, 2017 via email

@mbernier
Copy link

Thanks, @samundra!!

@mbernier mbernier removed difficulty: hard fix is hard in difficulty difficulty: medium fix is medium in difficulty difficulty: very hard fix is very hard in difficulty labels Oct 27, 2017
@samundra
Copy link
Contributor

Sorry, I was occupied. I finally got myself sometime. Starting from today, I still have few days left :)

@samundra
Copy link
Contributor

Hi @mbernier

I have created the early PR. Could you please review it?

I have tried to setup the basic docker based development. I am not so sure how I am supposed to write the USAGE document as per this box.

I have tried to keep it as much similar to the sendgrid/sendgrid-pythong docker box. So that usage won't vary much. Your insights would be helpful. Let me know how should I proceed forward with it.

Thanks,

@samundra
Copy link
Contributor

samundra commented Nov 2, 2017

Hi @mbernier,

I have a question on this issue. What are the services that should be created in docker-compose.yml.

As I see it the only service that should be running is prism with --mock argument.

I have added the instruction on how to build the docker image and use it to create container for test purpose.

@thinkingserious
Copy link
Contributor Author

Hi @samundra,

Yes, the only service that needs to be running is prism.

Thanks!

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants