Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove sudo requirement for running docker #737

Merged

Conversation

jamietanna
Copy link
Contributor

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

We shouldn't need to run Docker as root if it's been installed
correctly, and the user is already part of the docker group.

If this was not the case, we would've required other steps to be run
with sudo.

We shouldn't need to run Docker as root if it's been installed
correctly, and the user is already part of the `docker` group.

If this was not the case, we would've required other steps to be run
with `sudo`.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 13, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 13, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Hello @jamietanna,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino changed the title Remove sudo requirement for running docker docs: remove sudo requirement for running docker Jan 8, 2020
@childish-sambino childish-sambino merged commit 7c18a23 into sendgrid:master Jan 8, 2020
@thinkingserious
Copy link
Contributor

Hello @jamietanna,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants