Skip to content

Conversation

lifez
Copy link
Contributor

@lifez lifez commented Aug 3, 2018

Fixes

#584

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Since we install python with --no-install-recommends flag it will not bundle pip. So I add command to install pip in python3.6
  • Fix some pip install command

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #596 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          32       32           
  Lines         979      979           
  Branches      131      131           
=======================================
  Hits          848      848           
  Misses         67       67           
  Partials       64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac58c6...0ca2578. Read the comment docs.

@lifez lifez mentioned this pull request Aug 4, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: easy fix is easy in difficulty labels Aug 4, 2018
@thinkingserious
Copy link
Contributor

Thanks @lifez!

@af4ro af4ro added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Aug 13, 2018
@thinkingserious thinkingserious merged commit 7bb94ac into sendgrid:master Aug 16, 2018
@thinkingserious
Copy link
Contributor

Hello @lifez,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@lifez lifez deleted the fix-docker-build branch August 17, 2018 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants