Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reply_to to helpers.Mail #999

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Conversation

vindarel
Copy link
Contributor

Fixes

Add the reply_to keyword argument to helpers.mail.Mail.

Otherwise, we must create the Mail and then set the reply_to with
its setter (and we have to dig the repository to find out).

I didn't run the tests locally.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Otherwise, we must create the Mail and then set the reply_to thanks to
its setter.
(and we have to dig the code to find out).
@vindarel
Copy link
Contributor Author

helper-runner_1_f23ff83f7e70 | Ran 339 tests in 29.286s

helper-runner_1_f23ff83f7e70 | 

helper-runner_1_f23ff83f7e70 | OK

helper-runner_1_f23ff83f7e70 | <MagicMock name='Client().post().status_code' id='140154951636560'>

helper-runner_1_f23ff83f7e70 | <MagicMock name='Client().post().headers' id='140154951158992'>

helper-runner_1_f23ff83f7e70 | <MagicMock name='Client().post().body' id='140154951226704'>

helper-runner_1_f23ff83f7e70 | {}

prism_helper-runner_1_f23ff83f7e70 exited with code 0

Aborting on container exit...

Stopping prism_nginx_1_d5c65d2ecb6e         ... 

Stopping prism_prism_1_df1f6f32c7e1         ... 

The command "make test-docker" exited with 0.

yay o/

Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@@ -24,6 +24,7 @@ def __init__(
self,
from_email=None,
to_emails=None,
reply_to=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vindarel need to revert this change since

  • this breaks for the current users
  • reply_to is a little redundant here

Recommend just using the setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants