Skip to content

Php wrapper updates #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

Php wrapper updates #130

merged 1 commit into from
Nov 3, 2020

Conversation

rajatsib
Copy link
Contributor

@rajatsib rajatsib commented Nov 3, 2020 •
edited by aayush-sib
Loading

  • Change in length of sender
  • Fix security issue on sendReport routes
  • Made IP non-mandatory for getContactDetails route

@rajatsib
Php wrapper updates
822eb72 
- Change in length of sender [AP-803]
- Fix security issue on sendReport routes [AP-942]
- Made IP non-mandatory for getContactDetails route [AP-1036]
ekta-slit
ekta-slit approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@ekta-slit ekta-slit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajatsib rajatsib merged commit 6954f4c into master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekta-slit ekta-slit ekta-slit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatsib @ekta-slit