Skip to content

Conversation

sank3
Copy link

@sank3 sank3 commented Dec 30, 2021

Return type of SendinBlue\Client\Model\CreateContact::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

return type should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Return type should either be compatible with ArrayAccess return type or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
@Gwemox
Copy link

Gwemox commented Mar 3, 2022

Need to change php min version to 7.

@derWebdesigner
Copy link

Will this also be applied to SendSmtpEmail? Because this is the file where I see this deprecation note most often. Thank you very much in advance.

@deguif
Copy link

deguif commented Oct 3, 2022

There is this PR opened on swagger-codegen that should fix the issues with this library for PHP 8.1 : swagger-api/swagger-codegen#11846

Using mixed type as done here will require to bump PHP version to 8.x minimum.

@deguif
Copy link

deguif commented Oct 14, 2022

This has been merged in swagger-codegen (swagger-api/swagger-codegen#11846) but not yet released.
@preetishishodia7 @rajatsib do you think it will be possible to regenerate the models once it get officially released?

@deguif
Copy link

deguif commented Nov 22, 2022

@preetishishodia7
Copy link
Contributor

HI @sank3 can you please explain the reason/solution that why you create this pr, so that we can take further action.
Also we don't update this manually we update it from swagger based upon our other projects features.

@deguif
Copy link

deguif commented Dec 15, 2022

@preetishishodia7 your PR replaced this one. As adding #[\ReturnTypeWillChange] will fix the compatibility issues with PHP 8.1.

@deguif
Copy link

deguif commented Jan 5, 2023

Should be fixed with the latest release, published an hour ago

@preetishishodia7
Copy link
Contributor

This wrapper is auto generated using swagger, so we are not merging this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants