-
Notifications
You must be signed in to change notification settings - Fork 94
WF-2088 : php sdk update #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@preetishishodia7 would be nice to also test on 8.2, now it was released. Hi @deguif , in this current pr we have rolled out all features, we will upgrade PHP version in next pr due to some blockers. |
@preetishishodia7 this one should probably be merged: #124 |
Hey @preetishishodia7, if these library files are being manipulated using moustache templates or are being manually altered - please could you update the README in the repo root? It currently suggests that the autogenerated files are "as-is" and should not be altered manually (so anyone can autogenerate them) - this is no longer the case, and the README should reflect this. Thank you for your work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @preetishishodia7 |
This Merge causes Class SendinBlue\Client\Model\CreateUpdateProduct located in ./vendor/sendinblue/api-v3-sdk/lib/Model/CreateUpdateproduct.php does not comply with psr-4 autoloading standard. Skipping. |
ConversationsMessageFIleImageInfo has capital letter I in filename |
Hi @stkrelax Thanks for commenting, I'll update it asap. |
WF-2088