Skip to content

Conversation

preetishishodia7
Copy link
Contributor

@preetishishodia7 preetishishodia7 commented Dec 7, 2022

WF-2088

  • Allow country code when the phone number is passed
  • You can now enter an unsubscription page id to change the default unsubscription page.
  • Added update form id.
  • Changed default limit to 2500 and maximum limit to 5000 to /smtp/statistics/events
  • Limit decreases to 50 from 500 for the default result returned for Email campaigns
  • Set minimum value of all integer fields to 0
  • The segment_ids is mandatory if list ids are not used.
  • The isRecurring boolean field is added to create contact attributes endpoint

@deguif
Copy link

deguif commented Dec 12, 2022

@preetishishodia7 would be nice to also test on 8.2, now it was released.

Hi @deguif , in this current pr we have rolled out all features, we will upgrade PHP version in next pr due to some blockers.

@deguif
Copy link

deguif commented Dec 13, 2022

@preetishishodia7 this one should probably be merged: #124
It would avoid errors on CI you encountered previously as packages versions can vary depending on which PHP version is installed.

@pobtastic
Copy link

Hey @preetishishodia7, if these library files are being manipulated using moustache templates or are being manually altered - please could you update the README in the repo root? It currently suggests that the autogenerated files are "as-is" and should not be altered manually (so anyone can autogenerate them) - this is no longer the case, and the README should reflect this.

Thank you for your work.

Copy link
Contributor

@shubhamUpadhyayInBlue shubhamUpadhyayInBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preetishishodia7 preetishishodia7 merged commit de2367d into master Jan 5, 2023
@deguif
Copy link

deguif commented Jan 5, 2023

Thanks @preetishishodia7

@stkrelax
Copy link

stkrelax commented Jan 5, 2023

This Merge causes

Class SendinBlue\Client\Model\CreateUpdateProduct located in ./vendor/sendinblue/api-v3-sdk/lib/Model/CreateUpdateproduct.php does not comply with psr-4 autoloading standard. Skipping.
Class SendinBlue\Client\Model\FileList located in ./vendor/sendinblue/api-v3-sdk/lib/Model/FIleList.php does not comply with psr-4 autoloading standard. Skipping.
Class SendinBlue\Client\Model\ConversationsMessageFileImageInfo located in ./vendor/sendinblue/api-v3-sdk/lib/Model/ConversationsMessageFIleImageInfo.php does not comply with psr-4 autoloading standard. Skipping.

@stkrelax
Copy link

stkrelax commented Jan 5, 2023

ConversationsMessageFIleImageInfo has capital letter I in filename
CreateUpdateproduct needs capital P in filename
FIleList has capital letter I in Filename
@preetishishodia7

@preetishishodia7
Copy link
Contributor Author

Hi @stkrelax Thanks for commenting, I'll update it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants