Move dev deps to devDependencies in package.json #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually @types are only used in package development and are not needed in production. Moved to `devDependencies`: * `@types/bluebird` * `@types/request` and removed `rewire` because it was not used anywhere. * rewire
|
Hi @brandomeniconi |
|
Hi @aayush-sib, |
|
Hi @brandomeniconi |
|
Hi @aayush-sib, Just one last question, why do you still require I'll close this PR! |
|
It got missed somehow, I will remove it in the next release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We required this module in our app and it brokes our TS compile using ts-node because the package
@types/bluebirdis required in the production dependencies and it does some trickery to the TS compiler.Usually, `@types\ are only used in package development and are not needed in production, so I did the following:
Moved to devDependencies:
@types/bluebird@types/requestand removed
rewirebecause it was not used anywhere.If I missed something please let me know.