Skip to content

configurate logger #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2020
Merged

configurate logger #19

merged 1 commit into from
Jun 10, 2020

Conversation

DoubleDi
Copy link
Contributor

@DoubleDi DoubleDi commented Jun 9, 2020

This PR fixes #17

We make a logger from the route logger and apply some formatting changes, so we don't mess up the whole application logs.

Also made the default logging level warning, as it makes to much logs.

Please consider this PR and make a new version

yakshup
yakshup suggested changes Jun 10, 2020
View reviewed changes
Copy link

@yakshup yakshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to steer clear of setting formatter. The application, which is calling this library, might have separate format. It would be really confusing to get/pull separate format

@sendpulse sendpulse merged commit 6860d7a into sendpulse:master Jun 10, 2020
@sendpulse
Copy link
Owner

Thx all of you for your time and support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakshup yakshup yakshup requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interference with application logging
3 participants
@DoubleDi @sendpulse @yakshup