Skip to content

Fall back to open() if no editor is defined #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020
Merged

Fall back to open() if no editor is defined #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions til.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ const (
commitMessage: "build, save, push"
committerEmail: test@example.com
committerName: "TIL Autobot"
editor: "mvim"
editor: ""
targetDirectory: "~/Documents/til"
`
defaultEditor = "open"

fileExtension = "md"

Expand Down Expand Up @@ -407,9 +408,10 @@ func createNewPage(title string) string {
}

// Tell the OS to open the newly-created page in the editor (as specified in the config)
editor, err1 := globalConfig.String("editor")
if err1 != nil {
Fail(err1)
// If there's no editor explicitly defined by the user, tell the OS to try and open it
editor := globalConfig.UString("editor", defaultEditor)
if editor == "" {
editor = defaultEditor
}

cmd := exec.Command(editor, filePath)
Expand Down