Fix: Prevent segmentation fault when setting mana_credout or sycophant_dir

[alxbl]

I ran into this issue on a recent engagement. I recall it working before so it must have been introduced at some point.

The issue is that the mana_credout and sycophant_dir config entries are not initialized by hostapd_config_defaults and are freed without check when the config file is parsed.

The fix is simply to not free the strings, since these configurations cannot change at runtime anyway (As far as I can tell from a quick glance at the codebase, at least) .

I'm not sure if mana is still being maintained, but I thought I might as well share the changes with the community.

Cheers,
Alex

[alxbl]

After a little bit of digging, the issue was introduced in 8b529e7#diff-0034d76c981823550f0ad389932e838dR2188 which was prompted by LGTM suggestions. I think the os_free is a false positive here.

Alternatively, both settings could be initialized to reasonable defaults (NULL for mana_credout and /tmp/ for sycophant_dir and the os_free could be left in. The last word is yours.

Cheers,

[singe]

This is great, thank you for the fix and root cause finding. I was working on the hostapd 2.9 port and forgot about this.

[singe]

I reverted the lgtm fixes I put in place that caused this.