Project Setup #7
Conversation
src/TypeScriptBuilder.php
Outdated
| { | ||
| $files = []; | ||
| $dirs = []; | ||
| foreach ($this->typeScriptFilesPaths as $typeScriptFilePath) { |
There was a problem hiding this comment.
Si on utilise le bundle et qu'on a plusieurs niveau de dossier, on a une erreur: file_get_contents failed to open stream. Je pense que c'est important qu'on puisse avoir autant de niveau de dossier qu'on veut dans notre dossier typescript.
There was a problem hiding this comment.
Tu peux me donner plus d'info sur ta config et ton arbo stp ? je n'arrive pas à reproduire le bug
maelanleborgne
force-pushed
the
feature/project-setup
branch
from
905bf5d to
40786ea
Compare
maelanleborgne
force-pushed
the
feature/project-setup
branch
from
40786ea to
5499689
Compare
| parent::__construct(); | ||
| } | ||
|
|
||
| public function execute(InputInterface $input, OutputInterface $output): int |
There was a problem hiding this comment.
I opened an issue about this one. The compiler supports a watch option but it requires a node module, and even with the module installed it doesn't seem to work when running swc from the binary. So for now I'd say no, but maybe a Symfony FileWatcher component (or part of the FileSystem component) could solve this ;)
|
One thing I forgot! In 6.4, there is a new event - https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/AssetMapper/Command/AssetMapperCompileCommand.php#L65 The idea was to make bundles like this hook into that event, and run their build process. This will prevent users from needing to manually run |
|
|
||
| if (!$process->isSuccessful()) { | ||
| $output->error('TypeScript build failed'); | ||
| throw new \Exception('TypeScript build failed'); |
There was a problem hiding this comment.
| throw new \Exception('TypeScript build failed'); | |
| throw new \Exception(sprintf('Error compiling TypeScript: "%s"', $process->getErrorOutput())); |
There was a problem hiding this comment.
I don't think this is necessary since we output the buffer of the process while it's running. We would end up having the error message displayed twice
|
@weaverryan @WebMamba Thanks a lot for your reviews. I'll close this but feel free to notify me if there's anything else you'd like to see in the bundle or if you find any problem. 🙏 |
No description provided.