Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document etcd-cipher-suites backend config option #1472

Merged
merged 6 commits into from
May 22, 2019
Merged

Conversation

apaskulin
Copy link
Contributor

@apaskulin apaskulin commented May 16, 2019

Description

To do:

Motivation and Context

Closes #1468

Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list the supported ciphers? They can be found here:

https://golang.org/pkg/crypto/tls/#pkg-constants

The ciphers from TLS 1.0 - 1.2 are available, TLS 1.3 ciphers are not available. (But TLS 1.3 can be enabled in another way)

@@ -653,6 +654,22 @@ sensu-backend start --no-embed-etcd
# /etc/sensu/backend.yml example
no-embed-etcd: true{{< /highlight >}}


| etcd-cipher-suites | |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a default value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - an empty value will lead to the default etcd cipher suites being used. (I'm not sure what they are.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this doc: "empty will be auto-populated by Go". So maybe the values listed here would be the defaults?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@cwjohnston cwjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good for the release. It would be ideal if we can identify and document the defaults, but we don't need to be blocked by that.

@apaskulin apaskulin merged commit d515ab9 into master May 22, 2019
@apaskulin apaskulin deleted the etcd-cipher branch May 22, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add etcd-cipher-suites backend config option
3 participants