-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document etcd-cipher-suites backend config option #1472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we list the supported ciphers? They can be found here:
https://golang.org/pkg/crypto/tls/#pkg-constants
The ciphers from TLS 1.0 - 1.2 are available, TLS 1.3 ciphers are not available. (But TLS 1.3 can be enabled in another way)
@@ -653,6 +654,22 @@ sensu-backend start --no-embed-etcd | |||
# /etc/sensu/backend.yml example | |||
no-embed-etcd: true{{< /highlight >}} | |||
|
|||
|
|||
| etcd-cipher-suites | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - an empty value will lead to the default etcd cipher suites being used. (I'm not sure what they are.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That appears to be the case.
https://github.com/etcd-io/etcd/blob/master/embed/config.go#L187
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good for the release. It would be ideal if we can identify and document the defaults, but we don't need to be blocked by that.
Description
To do:
Motivation and Context
Closes #1468