Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark should return a denormalized entry #328

Closed
Glandos opened this issue May 19, 2023 · 1 comment
Closed

Bookmark should return a denormalized entry #328

Glandos opened this issue May 19, 2023 · 1 comment
Labels
Milestone

Comments

@Glandos
Copy link

Glandos commented May 19, 2023

As I test bookmarks in Ultrasonic, I notice that they're displayed without any details, even if they work. I've then got a list of unlabeled entries.

I've taken a look into Navidrome: https://github.com/navidrome/navidrome/blob/master/server/subsonic/bookmarks.go#L26
And Nextcloud/ownCloud music: https://github.com/owncloud/music/blob/master/lib/Db/BookmarkMapper.php#L31

They all de-normalize the bookmark entry, by returning the whole media details along with its ID, instead of just the ID. It seems that the client is not expected to do a second request to get media info.

I had a quick look at gonic, but I don't know have any idea to implement it for now.

@sentriz sentriz added the bug label May 20, 2023
@sentriz sentriz removed the bug label Jul 25, 2023
@sentriz sentriz added this to the v0.16.0 milestone Aug 31, 2023
sentriz added a commit that referenced this issue Sep 13, 2023
@Glandos
Copy link
Author

Glandos commented Sep 13, 2023

Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants