transcoding race condition #378
Labels
Comments
|
interesting. can you email me and example track and details of the transcode profile and bitrate settings |
|
also, 512 is a kind of crazy bitrate for a stereo signal, 128 is nearly transparent |
|
changing to
just to exclude teh caching from the equation then cmd.Wait() just triggers after the encoding is done, not when all the output of that is written to the writer, which then just flushes whatever has been written and the play stops after the player consumes that buffer. Take that as just pure assumption from my experience in other languages and common sense, I am probably 100% wrong 6a248fe that's the change that works for me, I am sure you can implement it properly, so I won't bother making PR for some hacky code. |
cacko
changed the title
|
hey i wasn't able to reproduce this. but i made a test to try reproduce it, maybe we can work on that in this test, a transcoding http server is start that serves 5s flac file -> opus a client reads it in a 5 second loop and verifies all the data is there. are you able to modify this test such that it breaks in the way you describe? thanks! |
|
don't bother mate, I'm sorted anb it seems nobody else to be complaining with same issue my opinion is your implementation of the pipe handling is wrong (same with navidrome but there it is just the caching that is messed up), but my knowledge of go is almost 0 so this is just presumptiuon from python stuff I've done exactly with ffmpeg/pipe/syncing etc. just logically if you do not bother with buffer why you even need the pipe ? just directly write to the http.response....right ? Anyway, let's assume I am wrong and it is my setup issue, so clops the issue. I am not writing all that with any ill intent, so do not feel insulted or wahtever, my opinion is mine, since I cannot prove it I accept yours. |
|
i'm not doubting your assumptions at all. i'm just not able to reproduce the issue that you describe (and also having trouble understanding some of the language you're using) you may be completely right, but it would be helpful if you made an edit to test added here. for example you could try make it fail with a high bitrate like you talked about, or a different file. just something reproducible would be very useful to me after you edit it, a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gonic version: master
I am not really sure what is going on, feels like buffer overflow or something similar, but when using transcode with some crazy high bitrate, it tends to stops. the gonic logs generally tells me nothing, all I can supply is ffplay debug logs, which does not tell much too
The text was updated successfully, but these errors were encountered: