Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause workers #64

Merged
merged 5 commits into from
Jan 7, 2013
Merged

Pause workers #64

merged 5 commits into from
Jan 7, 2013

Conversation

myronmarston
Copy link
Contributor

@dlecocq -- care to review this?

@proby
Copy link
Contributor

proby commented Jan 3, 2013

I like this (and the related qless-core) changes. Nice idea and work @myronmarston

@proby
Copy link
Contributor

proby commented Jan 3, 2013

I just had a thought about this. We should update the QlessUI such that it displays in some manner if a queue has been paused. For example, if a queue is paused it looks like this:

shard_traffic (paused)    | 0 / 0 / 0 / 0 / 8843 / 0 ...

and if it's unpaused it looks like normal:

shard_traffic             | 0 / 0 / 0 / 0 / 8843 / 0 ...

myronmarston added a commit that referenced this pull request Jan 7, 2013
@myronmarston myronmarston merged commit c6b021f into master Jan 7, 2013
@myronmarston myronmarston deleted the pause_workers branch January 7, 2013 20:06
@myronmarston
Copy link
Contributor Author

@proby -- your idea to add a UI indication is a great one. I was going to implement it when I realized that it'll require adding a qless-core is_paused command to do properly, which makes this more work than I originally thought. For now, I added an issue to come back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants