use EXPECT_RANGE_EQ in cli test #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have updated also the Readme file. An owner of "seqan" needs to enable Travis access for this repository, before we can see CI results. |
MitraDarja
reviewed
May 19, 2020
test/CMakeLists.txt
Outdated
| @@ -39,6 +39,7 @@ macro (add_app_test test_filename test_alternative) | |||
| # Add the test to its general target (cli or api). | |||
| if (${test_alternative} STREQUAL "CLI_TEST") | |||
| add_dependencies (${target} "${PROJECT_NAME}") # cli test needs the application executable | |||
| target_include_directories(${target} PUBLIC "${SEQAN3_INCLUDE_DIR}/../test/include") | |||
There was a problem hiding this comment.
Just a question: Why don't we have the source directory as a variable? Would make the path a bit more readable.
There was a problem hiding this comment.
Thank you for this suggestion; I found a solution with SEQAN3_CLONE_DIR which makes it indeed better readable.
test/cli/cli_test.hpp
Outdated
| @@ -6,6 +6,8 @@ | |||
| #include <sstream> // ostringstream | |||
| #include <string> // strings | |||
|
|
|||
| #include <seqan3/test/expect_range_eq.hpp> // EXPECT_RANGE_EQ macro | |||
There was a problem hiding this comment.
Should we mention why this is a useful macro, so that other people are more likely to use it?
MitraDarja
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SeqAn3 submodule and applies the EXPECT_RANGE_EQ macro in a command line interface test.
This PR closes seqan/product_backlog#4.