Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Decouple junctions and a cluster of junctions #51

Closed
Irallia opened this issue Feb 8, 2021 · 2 comments · Fixed by #61
Closed

[FEATURE] Decouple junctions and a cluster of junctions #51

Irallia opened this issue Feb 8, 2021 · 2 comments · Fixed by #61
Assignees

Comments

@Irallia
Copy link
Collaborator

Irallia commented Feb 8, 2021

After we added a first simple clustering method
eldariont left a comment:

However, I think that the implementation of the simple clustering method (including the corresponding changes to the junction class) could be improved. Proviously, the junction class represented a single junction detected from a single read. Now, it is also used to represent clusters of junctions. IMO, we should represent clusters of junctions with a decouple junctions and cluster of junctions. or a std::vector. Then, we could keep all the cluster-related information, such as the number of supporting reads, the read names, etc. separated from the information on a single junction.

We would like to create this new class.

@eldariont
Copy link
Collaborator

I have drafted a new class cluster which represents a set of junctions. Before creating a PR I would like to run and update the tests but cannot due to the problem reported in #48.

@Irallia Should I create a PR nevertheless or wait for a fix to the test issue?

@Irallia
Copy link
Collaborator Author

Irallia commented Feb 11, 2021

I have drafted a new class cluster which represents a set of junctions. Before creating a PR I would like to run and update the tests but cannot due to the problem reported in #48.

@Irallia Should I create a PR nevertheless or wait for a fix to the test issue?

I can checkout your branch and test it. Could you push your branch and give me the name?
I just noticed that we are not running our tests on Travis. I will try to set this up soon, that the tests are run online when you set a PR.

eldariont added a commit that referenced this issue Feb 15, 2021
This PR adds a new class cluster that represents a cluster of junctions by holding an std::vector<junction>. The new class implements public methods get_average_mate1() and get_average_mate2 to obtain the average of all junctions in the cluster. The PR also updates the simple clustering method to use the new cluster class. The PR resolves #51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants