Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BENCHMARKS] dataset comparison long read enhancement #209

Conversation

Irallia
Copy link
Collaborator

@Irallia Irallia commented May 24, 2022

Illumina Mate Pair

all DUP as INS
Illumina_Mate_Pair results all Illumina_Mate_Pair results DUP_as_INS all
Precision Recall
Illumina_Mate_Pair results pr_all Illumina_Mate_Pair results rec_all

Illumina Paired End

all DUP as INS
Illumina_Paired_End results all Illumina_Paired_End results DUP_as_INS all
Precision Recall
Illumina_Paired_End results pr_all Illumina_Paired_End results rec_all

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia self-assigned this May 24, 2022
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #209 (6e47b08) into master (71ad200) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   98.35%   98.34%   -0.01%     
==========================================
  Files          18       18              
  Lines         850      846       -4     
==========================================
- Hits          836      832       -4     
  Misses         14       14              
Impacted Files Coverage Δ
src/iGenVar.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ad200...6e47b08. Read the comment docs.

Copy link
Member

@joergi-w joergi-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@joshuak94
Copy link
Collaborator

So it looks like using just long reads still works much better than using both short and long reads combined? Also what is the difference between mate pair and paired-end?

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the TEST/benchmarks/dataset_comparison_long_read_enhancement branch 3 times, most recently from 779780e to c522483 Compare June 7, 2022 10:32
@Irallia Irallia force-pushed the TEST/benchmarks/dataset_comparison_long_read_enhancement branch 2 times, most recently from dbe00cb to fa2f6dd Compare June 7, 2022 12:05
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@Irallia Irallia force-pushed the TEST/benchmarks/dataset_comparison_long_read_enhancement branch from fa2f6dd to 6e47b08 Compare June 7, 2022 12:38
@Irallia
Copy link
Collaborator Author

Irallia commented Jun 7, 2022

So it looks like using just long reads still works much better than using both short and long reads combined? Also what is the difference between mate pair and paired-end?

Yes, I had a discussion with Knut today aswell. And yes it just looks like out short read calling is very bad.
We need to find out whats wrong there.

@Irallia Irallia merged commit 359c8e4 into seqan:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants