Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomerge/first cwl files #135

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SGSSGene
Copy link

@SGSSGene SGSSGene commented May 3, 2023

First try of generated cwl files for needle

@SGSSGene SGSSGene marked this pull request as draft May 3, 2023 17:05
Copy link
Contributor

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started leaving some comments; most can be applied to other places :-)

Comment on lines +44 to +48
- doc: "Please provide one sequence file with transcripts. Default: \"\". "
id: include
type:
- "null"
- string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a File, yes?

Comment on lines +51 to +57
- doc: "Please provide one *.genome file created with the genome command. Default: \"\". "
id: genome
type:
- "null"
- string
inputBinding:
prefix: --genome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another File

Comment on lines +2 to +8
- doc: "Directory where input files can be found. Default: \"./\". "
id: in
type:
- "null"
- string
inputBinding:
prefix: --in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need overriding. Are there specific file extensions expected?

Comment on lines +30 to +36
- doc: "Directory, where output files should be saved. Default: \"./\". "
id: out
type:
- "null"
- string
inputBinding:
prefix: --out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option should be suppressed

Comment on lines +30 to +36
- doc: "Directory, where output files should be saved. Default: \"./\". "
id: out
type:
- "null"
- string
inputBinding:
prefix: --out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option should be suppressed

Comment on lines +79 to +85
- doc: "Sequence file containing minimizers that should not be stored. Default: \"\". "
id: exclude
type:
- "null"
- string
inputBinding:
prefix: --exclude
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File

Comment on lines +86 to +92
- doc: "Define which samples belong together, sum has to be equal to number of sequence files. Default: Every sequence file is one sample from one experiment. Default: []. "
id: samples
type:
- "null"
- boolean
inputBinding:
prefix: --samples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this type is wrong...

Comment on lines +100 to +106
- doc: "If set, names of the experiments are stored in a txt file. Default: 0. "
id: experiment-names
type:
- "null"
- boolean
inputBinding:
prefix: --experiment-names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment on lines +107 to +113
- doc: "Sequence file containing minimizers, only those minimizers will be considered for determining the expression thresholds. Default: \"\". "
id: levels-by-genome
type:
- "null"
- string
inputBinding:
prefix: --levels-by-genome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another File?

Comment on lines +2 to +8
- doc: "Directory, where output files should be saved. Default: \"./\". "
id: out
type:
- "null"
- string
inputBinding:
prefix: --out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option should be suppressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants