Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] introduce ranges::to; remove implicit conversions #1033

Merged
merged 1 commit into from
May 31, 2019

Conversation

h-2
Copy link
Member

@h-2 h-2 commented May 30, 2019

fixes #915

Since the views from the range library are still implicitly convertible, I might have missed a case or two, but we can fix that when upstream changes or we have a C++20 implementation to test against.

None of our views are implicitly convertible anymore.

@h-2 h-2 requested a review from eseiler May 30, 2019 14:36
Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

test/unit/range/view/view_to_rank_test.cpp Show resolved Hide resolved
@h-2 h-2 removed the request for review from eseiler May 31, 2019 10:20
@h-2 h-2 merged commit 6810ac1 into seqan:master May 31, 2019
@h-2 h-2 mentioned this pull request May 31, 2019
@h-2 h-2 mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move form implicit conversion to ranges::to
2 participants