New views #1410
Merged
New views #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
==========================================
+ Coverage 97.59% 97.59% +<.01%
==========================================
Files 232 234 +2
Lines 8783 8789 +6
==========================================
+ Hits 8572 8578 +6
Misses 211 211
Continue to review full report at Codecov.
|
eseiler
approved these changes
Dec 9, 2019
rrahn
requested changes
Dec 10, 2019
| * \ingroup type_traits | ||
| */ | ||
| template <typename ...invocable_ts> | ||
| struct multi_lambda : invocable_ts... |
There was a problem hiding this comment.
Mhmm, multi lambda is not such a good name. I mean it would work with any invocable not just lambdas.
So what about: multi_invocable invocable_pool invocable_union?
| //!\brief Function object for seqan3::views::as_const. | ||
| struct as_const_fn | ||
| { | ||
| //!\brief Operator for returning values as values. |
There was a problem hiding this comment.
Suggested change
| //!\brief Operator for returning values as values. | |
| //!\brief Operator for returning rvalue as prvalue. |
There was a problem hiding this comment.
Maybe link to the value categories of std as well.
There was a problem hiding this comment.
But it doesn't change the value category.
| { | ||
| std::string const vec{"foobar"}; | ||
| std::string_view v = vec | seqan3::views::type_reduce; // pipe notation; v is of type std::string_view | ||
| seqan3::debug_stream << v << '\n'; // "foobar" |
|
|
||
| std::vector vec2{1, 2, 3}; | ||
| std::span v2 = seqan3::views::type_reduce(vec2); // functional notation; v is of type std::span | ||
| seqan3::debug_stream << v2 << '\n'; // "[1, 2, 3]" |
rrahn
requested changes
Dec 17, 2019
| return std::move(arg); | ||
| } | ||
|
|
||
| //!\brief Operator for returns lvalue references as lvalue-to-const-references. |
There was a problem hiding this comment.
Suggested change
| //!\brief Operator for returns lvalue references as lvalue-to-const-references. | |
| //!\brief Operator that returns lvalue references as lvalue-to-const-references. |
|
Don't know what's going on with Jenkins here. |
rrahn
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
views::moveviews::as_constviews::all→views::simplify_type