Add typed test to kmer_hash #1722
Conversation
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
from
97bed7d
to
71dd793
Compare
Codecov Report
@@ Coverage Diff @@
## master #1722 +/- ##
==========================================
- Coverage 97.66% 97.62% -0.05%
==========================================
Files 239 239
Lines 9089 9062 -27
==========================================
- Hits 8877 8847 -30
- Misses 212 215 +3
Continue to review full report at Codecov.
|
MitraDarja
requested review from
a team and
marehr
and removed request for
a team
|
@marehr When you review, can you also take a look at the code coverage test failure? I don't understand, why the coverage drops in take_until... I am using it as it was used before. |
|
@marehr polite ping |
There was a problem hiding this comment.
Sorry for the late review. I must somehow marked it as read in https://github.com/notifications.
|
@marehr I have now made all tests typed tests, only the tests based on previous issues are not typed tests. I am not sure, if it makes sense for the issue_tests to be typed as well. I have not made an extra test for testing the combined_with_other_views when using the stop_at_thymine view, because that would have added only one test case for gapped and ungapped, while adding more lines. So I put them in the combined_with_container tests for a shorter code, I hope that is okay. |
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
from
cc81e1a
to
19ee553
Compare
| result_t gapped4{gapped2}; | ||
| static constexpr auto ungapped_view = seqan3::views::kmer_hash(seqan3::ungapped{3}); | ||
| static constexpr auto gapped_view = seqan3::views::kmer_hash(0b101_shape); | ||
| static constexpr auto prefix_until_first_thymine = seqan3::views::take_until([] (seqan3::dna4 x) |
There was a problem hiding this comment.
maybe put that into the type test class kmer_hash_properties_test
There was a problem hiding this comment.
You wrote me that you couldn't make this work. Since these are view adaptors, it is fine for me to put them here.
I'm wondering why TestFixture::ungapped_view wasn't working.
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
from
a03b0a8
to
fabd880
Compare
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
2 times, most recently
from
abed13c
to
d12333c
Compare
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
2 times, most recently
from
2d14c6e
to
81c330e
Compare
There was a problem hiding this comment.
You can rebase on the current master now and use the EXPECT_RANGE_EQ (see #1764 for examples) and then the Jenkins error should go away.
Then we can merge this.
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
from
81c330e
to
8258b11
Compare
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
from
8258b11
to
77a58f6
Compare
MitraDarja
force-pushed
the
kmer_hash_typed_test
branch
from
77a58f6
to
8cd8edd
Compare
Add a typed_test to kmer_hash to reduce code lines, while testing more. Found and solves the bug #1719.