Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Repair seqan2 tests #1995

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

Irallia
Copy link
Contributor

@Irallia Irallia commented Jul 28, 2020

This PR is part of seqan/product_backlog#12.
It resolves the errors with seqan2, such as

.../seqan3/test/performance/range/views/view_translate_2D_1D_benchmark.cpp: In function 'void copy(benchmark::State&)':
.../seqan3/test/performance/range/views/view_translate_2D_1D_benchmark.cpp:195:38: error: 'generate_sequence_seqan' was not declared in this scope; did you mean 'seqan3::test::generate_sequence_seqan2'?
  195 |         dna_sequence_collection[i] = generate_sequence_seqan2<seqan::Dna>(100, 0, 0);
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                      seqan3::test::generate_sequence_seqan2

and

.../seqan3/test/performance/alignment/global_affine_alignment_parallel_benchmark.cpp: In function 'void seqan2_affine_dna4_parallel(benchmark::State&)':
.../seqan3/test/performance/alignment/global_affine_alignment_parallel_benchmark.cpp:144:5: error: 'ExecutionPolic' was not declared in this scope; did you mean 'seqan::ExecutionPolicy'?
  144 |     ExecutionPolicy<Parallel, Serial> exec{};
      |     ^~~~~~~~~~~~~~~
      |     seqan::ExecutionPolicy

when the seqan submodule is available.

@Irallia Irallia self-assigned this Jul 28, 2020
@Irallia Irallia requested review from a team and simonsasse and removed request for a team July 28, 2020 15:47
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1995 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1995   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         262      262           
  Lines        9865     9865           
=======================================
  Hits         9657     9657           
  Misses        208      208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9785709...90927b6. Read the comment docs.

Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
@marehr marehr requested review from eseiler and removed request for simonsasse July 29, 2020 23:46
@eseiler eseiler merged commit b2c1107 into seqan:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants