alphabet 02: things that are marked stable / experimental. #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marehr
requested review from
a team and
joergi-w
and removed request for
a team
marehr
commented
Feb 17, 2021
| @@ -37,41 +37,42 @@ enum class third_party_type | |||
| template <> | |||
| struct seqan3::custom::alphabet<third_party_ns::third_party_type> | |||
| { | |||
| using alphabet_t = typename third_party_ns::third_party_type; | |||
There was a problem hiding this comment.
../../seqan3/test/unit/alphabet/custom_alphabet3_test.cpp:40:49: error: declaration ‘enum class third_party_ns::third_party_type’ does not declare anything [-Werror]
40 | using alphabet_t = typename third_party_ns::third_party_type;
| ^~~~~~~~~~~~~~~~
eseiler
reviewed
Feb 17, 2021
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/gsnrblneg |
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 266 266
Lines 10835 10835
=======================================
Hits 10642 10642
Misses 193 193
Continue to review full report at Codecov.
|
joergi-w
requested changes
Feb 17, 2021
eseiler
reviewed
Feb 17, 2021
eseiler
approved these changes
Feb 17, 2021
|
Huh? I didn't need to do anything xD Thank you all! |
|
You could rebase my small changes if you want to |
done |
marehr
force-pushed
the
api_stability2
branch
from
4883ffa
to
130fd6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was decided in the Core-Meeting 2021-02-15