Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move seqan3::cigar_op into seqan3::cigar class. #2426

Merged
merged 4 commits into from
Mar 5, 2021
Merged

Move seqan3::cigar_op into seqan3::cigar class. #2426

merged 4 commits into from
Mar 5, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Mar 3, 2021 •
edited
Loading

@marehr marehr requested review from a team and SGSSGene and removed request for a team March 3, 2021 17:50
@vercel
Copy link

vercel bot commented Mar 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/Dr6n7YqKrPMd3RtEwJ6S56c6v8wN
✅ Preview: https://seqan3-git-fork-marehr-cigaroperation04-seqan.vercel.app

@codecov
Copy link

codecov bot commented Mar 4, 2021 •
edited
Loading

Codecov Report

Merging #2426 (fac3a86) into master (6dfc894) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2426   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         267      266    -1     
  Lines       10917    10919    +2     
=======================================
+ Hits        10725    10727    +2     
  Misses        192      192
Impacted Files Coverage Δ
include/seqan3/alphabet/cigar/cigar.hpp 91.30% <100.00%> (+0.82%) ⬆️
include/seqan3/io/sam_file/detail/cigar.hpp 97.01% <100.00%> (+0.09%) ⬆️
...lude/seqan3/io/sam_file/detail/format_sam_base.hpp 98.12% <100.00%> (ø)
include/seqan3/io/sam_file/format_bam.hpp 96.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dfc894...771d733. Read the comment docs.

SGSSGene
SGSSGene approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@SGSSGene SGSSGene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍

@SGSSGene SGSSGene requested review from a team and eseiler and removed request for a team March 4, 2021 12:17
eseiler
eseiler requested changes Mar 5, 2021
View reviewed changes
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 💅

Do you already want to do a changelog for this? Or will you/we do it later?

include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
include/seqan3/alphabet/cigar/exposition_only/cigar_operation.hpp Outdated Show resolved Hide resolved
test/snippet/alphabet/cigar/cigar_get_index.cpp Outdated Show resolved Hide resolved
test/snippet/alphabet/cigar/cigar_get_type.cpp Outdated Show resolved Hide resolved
@marehr
Copy link
Member Author

marehr commented Mar 5, 2021

Just nail_care

Do you already want to do a changelog for this? Or will you/we do it later?

I would do it in the next where I reintroduce seqan3::cigar_op with a deprecation notice.

@marehr marehr force-pushed the cigar_operation04 branch 2 times, most recently from 21824aa to a16af16 Compare March 5, 2021 14:57
eseiler
eseiler approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@marehr
[FEATURE] new seqan3::cigar::operation
1396e6d 
This commit does multiple things:

* mark entities within seqan3::cigar/::operations stable
* moves extra alphabet seqan3::cigar_op into seqan3::cigar::operation
* adds the actual implementation seqan3::cigar::operation
  (former seqan3::cigar_op) to seqan3::exposition_only::cigar_operation
@marehr
[MISC] mark cigar as stable
771d733
@eseiler eseiler merged commit fddd897 into seqan:master Mar 5, 2021
@marehr marehr deleted the cigar_operation04 branch March 5, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGSSGene SGSSGene SGSSGene approved these changes

@eseiler eseiler eseiler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marehr @SGSSGene @eseiler