[MISC] Alphabet: deprecate phred_type constructor #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/EE48YZ8W2UkFoTPFkxRzV4Nbdx3d |
Irallia
force-pushed
the
API/alphabet/deprecate_phred_type_constructor
branch
from
bfd896e
to
30669a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2537 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 269 269
Lines 10541 10535 -6
==========================================
- Hits 10355 10349 -6
Misses 186 186
Continue to review full report at Codecov.
|
marehr
reviewed
Apr 20, 2021
| /*!\brief Allow construction from the Phred score value. | ||
| * \details | ||
| * \deprecated This will be removed in 3.1.0. Please use seqan3::phred42::assign_phred() or '!'_phred42. | ||
| */ | ||
| constexpr phred42(phred_type const p) : base_t{p} {} |
There was a problem hiding this comment.
Suggested change
| constexpr phred42(phred_type const p) : base_t{p} {} | |
| SEQAN3_DEPRECATED_310 constexpr phred42(phred_type const p) : base_t{p} {} |
Irallia
force-pushed
the
API/alphabet/deprecate_phred_type_constructor
branch
from
30669a1
to
131e644
Compare
eseiler
reviewed
Apr 21, 2021
CHANGELOG.md
Outdated
| @@ -127,6 +127,11 @@ regression test suite and patches at https://github.com/seqan/seqan3/tree/master | |||
| * Renamed `seqan3::phred68legacy` to `seqan3::phred68solexa` ([\#2522](https://github.com/seqan/seqan3/pull/2522)). | |||
| * Renamed `seqan3::sam_dna16` to `seqan3::dna16sam` | |||
| ([\#2521](https://github.com/seqan/seqan3/pull/2521)). | |||
| * Removed phred constructors instead ([\#2537](https://github.com/seqan/seqan3/pull/2537)): | |||
| * Use instead of `seqan3::phred42{0}` constructor `seqan3::phred42::assign_phred(0)` or `'!'_phred42`. | |||
There was a problem hiding this comment.
Suggested change
| * Use instead of `seqan3::phred42{0}` constructor `seqan3::phred42::assign_phred(0)` or `'!'_phred42`. | |
| * Use instead of `seqan3::phred42(phred_type)` constructor `seqan3::phred42::assign_phred()` or `seqan3::operator""_phred42`. |
Irallia
force-pushed
the
API/alphabet/deprecate_phred_type_constructor
branch
from
131e644
to
be93733
Compare
Irallia
force-pushed
the
API/alphabet/deprecate_phred_type_constructor
branch
from
a1d535b
to
d7e077c
Compare
marehr
requested review from
a team and
SGSSGene
and removed request for
a team
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Used initialiser list in gcc7 instead of count,value ctor Co-authored-by: Enrico Seiler <enrico.seiler@hotmail.de> Co-authored-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Irallia
force-pushed
the
API/alphabet/deprecate_phred_type_constructor
branch
from
d7e077c
to
62180e1
Compare
eseiler
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves seqan/product_backlog#316