Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/avx512 transform #2920

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Conversation

rrahn
Copy link
Contributor

@rrahn rrahn commented Dec 18, 2021

This PR fixes issues with AVX512 transform and adds an efficient transform operation of a 64x64 matrix using AVX512 instructions.
This feature has a great impact on the performance of the SIMD alignment code on AVX512.
It is only available for CPUs with __AVX512BW__ support and otherwise falls back to the less efficient transform operation.

…ng AVX512.

The AVX512 call of transpose caused an infinite recursive call of the function due to constraint overloading.
The default auto-vectorisation is now moved into a detail function and called explicitly.
@rrahn rrahn requested review from a team and Irallia and removed request for a team December 18, 2021 12:39
@vercel
Copy link

vercel bot commented Dec 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/8kveCY8T3fghcNxc2fDs7dKQujBJ
✅ Preview: https://seqan3-git-fork-rrahn-feature-avx512transform-seqan.vercel.app

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #2920 (03c5893) into master (cf4e1d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2920   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         267      267           
  Lines       11459    11462    +3     
=======================================
+ Hits        11262    11265    +3     
  Misses        197      197           
Impacted Files Coverage Δ
include/seqan3/utility/simd/algorithm.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4e1d7...03c5893. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your explanation. LGFM 👍

@Irallia Irallia requested review from a team and eseiler and removed request for a team January 5, 2022 09:58
@eseiler eseiler merged commit d1dc631 into seqan:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants