Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IO] Make seqan3::sam_file_header::program_info_t easier to copy #3145

Merged
merged 4 commits into from
Apr 25, 2023
Merged

[IO] Make seqan3::sam_file_header::program_info_t easier to copy #3145

merged 4 commits into from
Apr 25, 2023

Conversation

tsnorri
Copy link
Contributor

@tsnorri tsnorri commented Apr 20, 2023 •
edited
Loading

Fixes #3137.

@vercel
Copy link

vercel bot commented Apr 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 9:44am

@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Apr 20, 2023
@tsnorri tsnorri changed the title Fix #3137 ([IO] Make seqan3::sam_file_header::program_info_t easier to copy) [IO] Make seqan3::sam_file_header::program_info_t easier to copy Apr 20, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 20, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 20, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 20, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 21, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (82c3fd8) 98.18% compared to head (1a07f35) 98.18%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3145   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         276      276           
  Lines       12292    12294    +2     
=======================================
+ Hits        12069    12071    +2     
  Misses        223      223
Impacted Files Coverage Δ
include/seqan3/io/sam_file/header.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tsnorri tsnorri marked this pull request as ready for review April 21, 2023 10:43
@tsnorri tsnorri marked this pull request as draft April 21, 2023 10:52
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 21, 2023
@tsnorri tsnorri marked this pull request as ready for review April 21, 2023 11:37
@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Apr 24, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 24, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 24, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 24, 2023
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 24, 2023
@smehringer
Copy link
Member

Nice thank you :) I just reference the issue in the test. After CI is though we can merge.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Apr 25, 2023
@eseiler eseiler merged commit aa502ef into seqan:master Apr 25, 2023
@eseiler
Copy link
Member

eseiler commented Apr 25, 2023

Thanks again! If you want to be added as author to header.hpp, let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler left review comments

@smehringer smehringer smehringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IO] Make seqan3::sam_file_header::program_info_t easier to copy
4 participants
@tsnorri @smehringer @eseiler @seqan-actions