Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Refine unknown tag handling (HD/PG) #3248

Merged
merged 1 commit into from
May 31, 2024
Merged

[MISC] Refine unknown tag handling (HD/PG) #3248

merged 1 commit into from
May 31, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Mar 1, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
seqan3 ✅ Ready (Inspect) Visit Preview May 31, 2024 10:46am

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Mar 1, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Mar 1, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (bcc142e) to head (3df554f).
Report is 1 commits behind head on main.

❗ Current head 3df554f differs from pull request most recent head b638661

Please upload reports for the commit b638661 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3248      +/-   ##
==========================================
- Coverage   98.18%   98.17%   -0.01%     
==========================================
  Files         269      269              
  Lines       11872    11871       -1     
==========================================
- Hits        11656    11654       -2     
- Misses        216      217       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Mar 1, 2024
rrahn
rrahn requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except this little safety const everything looks good to me! Thanks!

include/seqan3/io/sam_file/detail/format_sam_base.hpp Outdated Show resolved Hide resolved
@eseiler eseiler requested a review from rrahn May 21, 2024 09:42
@eseiler eseiler enabled auto-merge May 21, 2024 09:42
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 21, 2024
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels May 31, 2024
rrahn
rrahn approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awsome!

@eseiler eseiler merged commit 21c7d04 into seqan:main May 31, 2024
32 checks passed
@eseiler eseiler deleted the misc/refine_tags branch May 31, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrahn rrahn rrahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eseiler @rrahn @seqan-actions