Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch cli-color to ansis #1507

Closed
wants to merge 1 commit into from
Closed

refactor: switch cli-color to ansis #1507

wants to merge 1 commit into from

Conversation

webdiscus
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • [x ] Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

Hello @WikiRik,

I'm the author of the ansis which you already know.

This PR switch the cli-color to ansis package, because:

Screenshot 2024-06-07 at 11 43 33
Screenshot 2024-06-07 at 11 44 03

@webdiscus
Copy link
Author

webdiscus commented Jun 7, 2024

@WikiRik

should the sequelize-cli package really supports node-10 in 2024? I can add the supports for node-10, if it is need.
Maybe change the CI test from node-version: [10, 16] to [16, 18, 20]?
The sequelize uses node-version: [18, 20] for testing.

@webdiscus webdiscus marked this pull request as ready for review June 7, 2024 11:04
@WikiRik
Copy link
Member

WikiRik commented Jun 7, 2024

We're replacing sequelize-cli with @sequelize/cli in v7 (which is in the monorepo you've already updated). For v6 (the current version) we will keep supporting Node 10, so I'll close this PR since we have no need to switch here.
Thanks for opening the PR anyway!

@WikiRik WikiRik closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants