Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequelize to the latest version 🚀 #468

Merged
merged 4 commits into from
Jun 14, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jun 7, 2017

Version 4.0.0 of sequelize just got published.

Dependency sequelize
Current Version 3.30.4
Type devDependency

The version 4.0.0 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of sequelize.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Commits

The new version differs by 427 commits ahead by 427, behind by 98.

  • d960cf1 4.0.0
  • 8a4b529 docs: more resource link + fix incorrect changelog link
  • 411f89e New stable
  • a270d23 Docs: Added v3 to v4 migration guide (#7740)
  • fdf95dd fixed #7735, sqlite memory url no longer works (#7736)
  • b7ca3c4 docs: pretty color + reference theme
  • 2651f98 docs: update theme + changelog + logo
  • bfee712 fix: pooling fails to handle disconnection (#7698)
  • 41408df added: npm run sscce support
  • 567c3e5 Add relative and full path support for sqlite (#7700)
  • 6a84ba8 Amplify docs for "import" instruction (#7695)
  • 2934278 Closes #7709 [ci skip]
  • 4392201 #7184 Regression in affected rows reporting for updates (#7423)
  • 13a3f1e Fix documentation of include.paranoid (#7672)
  • b0bd5d0 [ci skip] git ignore package-lock.json

There are 250 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@mention-bot
Copy link

@Greenkeeper[bot], thanks for your PR! By analyzing the history of the files in this pull request, we identified @greenkeeperio-bot, @sushantdhiman and @Greenkeeper to be potential reviewers.

@Americas Americas force-pushed the greenkeeper/sequelize-4.0.0 branch from 1a36abb to a8fb8d6 Compare June 14, 2017 10:59
@Americas Americas self-assigned this Jun 14, 2017
@Americas Americas merged commit e00a8f9 into master Jun 14, 2017
@Americas Americas deleted the greenkeeper/sequelize-4.0.0 branch June 14, 2017 14:06
@geluso
Copy link

geluso commented Jun 16, 2017

Does this merge mean sequelize-cli will create models appropriately for sequelize@4.0.0? There's one breaking change I've been beating my head against recently.

"classMethods and instanceMethods are removed."

If sequelize-cli truly supports sequelize@4.0.0 the model template needs to move the associate function outside of classMethods, which was removed.

Here's someone doing a similar change in the sequelize/express-example:

sequelize/express-example@0745b9d

Here's the template that needs to be updated.

https://github.com/sequelize/cli/blob/master/lib/assets/models/model.js

Please tell me yes/no if sequelize-cli should support sequelize@4.0.0 like this. I understand it's a forward-moving, breaking change!

codetriage-readme-bot pushed a commit to codetriage-readme-bot/cli that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants